Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hydration optimisation #6290

Merged
merged 4 commits into from
May 3, 2021

Conversation

Conduitry
Copy link
Member

This reverts the buggy hydration optimisation from #6204 for the time being.

Are there some tests from other PRs that we might as well pull in now, or should that be separate?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. The test from #6283 might be worth including. But you could merge this, revert the code changes from that PR, and then merge that one if it's easier than trying to pull them in here

@Conduitry
Copy link
Member Author

👍 Yup, I've now cherry picked the two commits from that PR that added tests.

@Conduitry Conduitry merged commit 6d16e92 into sveltejs:master May 3, 2021
@Conduitry Conduitry deleted the revert-hydration-optimisation branch May 3, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants