Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tutorial] Update Chapter 19 to reference Svelte Kit #6284

Merged
merged 4 commits into from
May 3, 2021
Merged

[Tutorial] Update Chapter 19 to reference Svelte Kit #6284

merged 4 commits into from
May 3, 2021

Conversation

alexiglesias93
Copy link
Contributor

@alexiglesias93 alexiglesias93 commented May 2, 2021

Maybe this is intentional and the Svelte team prefers to wait until the stable v1.0 version is released, I'm just opening this PR to keep track of this as I haven't found any existing issue or PR mentioning it.

Haven't run any tests as it's just a simple markdown change.

Maybe this is intentional and the Svelte team prefers to wait until the v1.0.0 version is released, I'm just opening this PR to keep track of this as I haven't found any existing issue or PR mentioning it.
@peopledrivemecrazy
Copy link
Contributor

Sapper is going to remain, both sveltekit and sapper is going to have routing, SSR, etc, I would prefer both of them documented.

@@ -6,6 +6,6 @@ You've now finished the Svelte tutorial and are ready to start building apps. Yo

To get set up in your local development environment, check out [the quickstart guide](blog/the-easiest-way-to-get-started).

If you're looking for a more expansive framework that includes routing, server-side rendering and everything else, take a look at [Sapper](https://sapper.svelte.dev).
If you're looking for a more expansive framework that includes routing, server-side rendering and everything else, take a look at [Svelte Kit](https://kit.svelte.dev).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're looking for a more expansive framework that includes routing, server-side rendering and everything else, take a look at Sapper and Svelte Kit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sapper is basically EOL at this point. I think the original edit was preferable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back to just reference Svelte Kit

@benmccann benmccann merged commit 341160f into sveltejs:master May 3, 2021
@benmccann
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants