[fix] wrong len in draw transition #6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
added
runtime
benmccann
changed the title
dummdidumm
reviewed
Sep 10, 2021
| const len = node.getTotalLength(); | ||
| let len = node.getTotalLength(); | ||
| if (getComputedStyle(node).strokeLinecap !== 'butt') { | ||
| len += parseInt(getComputedStyle(node).strokeWidth); |
There was a problem hiding this comment.
This was merged, so I'm a little late possibly, but what are the performance implications of calling getComputedStyle twice here? It at least could be deduplicated to one call.
There was a problem hiding this comment.
Oh, whoops. It's probably not ideal. I'd definitely merge a PR that just called it once and saved the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the strokeWith to the len in the draw transistion if the strokeLinecap is 'round' or 'square',
that fixes issue #4540.
Tests
npm testand lint the project withnpm run lint