-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds resize observer functionality #5963
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6705c53
Adds resize observer functionality
jacwright 5aba3ee
Merge branch 'master' into resize-observer
jacwright a6a5bc7
Merge branch 'master' into resize-observer
jacwright 2323059
Reverting package-lock.json to master version
jacwright 1f3205f
Merge branch 'master' into resize-observer
Rich-Harris 1572a47
Update src/compiler/compile/nodes/Binding.ts
Rich-Harris 6d8515c
Merge branch 'master' into pr/jacwright/5963
bluwy 45221be
fix sizing regex
bluwy fb529ef
throw error for unsupported browser in dev
bluwy 1e9b3fc
use dev variant
bluwy 8a1a62e
fix ts errors
bluwy 3317eb3
fix invalid binding error report
bluwy 1ac349f
remove has_arg
bluwy d5947a2
add resize observer options
bluwy ede723f
split binding events
bluwy 8783ad2
typo
bluwy f08ee39
ts typo
bluwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -630,6 +630,13 @@ export function add_resize_listener(node: HTMLElement, fn: () => void) { | |
}; | ||
} | ||
|
||
export function add_resize_observer(node: HTMLElement, fn: () => void, opts?: any) { | ||
// @ts-ignore ResizeObserver is not available in current tsconfig lib | ||
const observer = new ResizeObserver(entries => fn.call(entries.values().next().value)); | ||
observer.observe(node, opts); | ||
return () => observer.disconnect(); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i wonder if we could / should reuse the |
||
export function toggle_class(element, name, toggle) { | ||
element.classList[toggle ? 'add' : 'remove'](name); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont have to do this here, any runtime function suffixed with
_dev
will be automatically used when thedev
mode istrue