Uses ResizeObserver on resize listeners if available
#5885
Conversation
As discussed in sveltejs#4233, ResizeObserver is now widely available (~90% as of 15/01/2021, [source](http://caniuse.com/?search=ResizeObserver)) so we can use it instead of a custom-built solution to listen to resizes. I also needed to add @types/resize-observer-browser because the type definition for `ResizeObserver` hasn't landed in TS yet (see microsoft/TypeScript#28502). Closes sveltejs#4233.
|
I might be wrong, but the failure looks like a flake 🤔 |
|
I wonder if there could be some sort of flag to allow the old implementation not be included at all? |
|
@porfirioribeiro that sounds like a great idea! It was already suggested in #4233 by @Prinzhorn. I'd be happy to work on it too but it sounds like it would be better to do that in a separate PR. The only caveat is I'm not sure if there's a precedent for this kind of feature (this sounds like we'd need to add a new option to the compiler). If there isn't a feature like it then I'm not convinced it's worth the extra complexity it might add to the compiler config consider how little we stand to gain from it (hopefully someone from the Svelte team can chime in). |
|
duplicate #5524 |
|
It seems like this PR wouldn't be accepted as is for the reason mentioned in #5524 (comment). We'd have to come up with a solution to Rich's concern there. I'm going to close this to keep the discussion in a single place |
As discussed in #4233, ResizeObserver is now widely available (~90% as of 15/01/2021, source) so we can use it instead of a custom-built solution to listen to resizes.
I also needed to add @types/resize-observer-browser because the type definition for
ResizeObserverhasn't landed in TS yet (see microsoft/TypeScript#28502).Closes #4233.
Testing: