Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deconflict variable for action and each block #5839

Merged
merged 5 commits into from
Jan 4, 2021

Conversation

tanhauhau
Copy link
Member

Fixes #5834

Before submitting the PR, please make sure you do the following

- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

I'm seeing compiler exceptions of TypeError: Cannot read property 'template_scope' of null during several of the tests.

@Conduitry Conduitry marked this pull request as draft January 2, 2021 01:01
@tanhauhau tanhauhau marked this pull request as ready for review January 2, 2021 02:39
@Conduitry Conduitry merged commit 7342570 into sveltejs:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import variables conflicting with #each block variable
2 participants