Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TypeScript version #5758

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Bump TypeScript version #5758

merged 1 commit into from
Dec 14, 2020

Conversation

benmccann
Copy link
Member

Just a bit of housekeeping. Sticking with the 3.x series for now

@benmccann benmccann requested a review from dummdidumm December 8, 2020 19:49
@Conduitry
Copy link
Member

I haven't looked into where the dependency is coming from, but is it possible to also update tsutils so that we don't need to have two versions of tslib?

@dummdidumm
Copy link
Member

dummdidumm commented Dec 8, 2020

TypeScript does not follow semver, there are breaking changes in-between or new type features. We would need to look into what's changed between our old and the new version to make sure we cannot accidentally add new type features that would break people. That said, even if we bump to the latest version, I doubt we will do that much type ninja stuff that it would really matter.

Edit: just read that we need 3.7+ for optional chaining to work. I'm ok to bump to that version if it makes writing code easier.
When bumping we should check the new generated js and dts output to look the same as previously.
Things to watch out for: https://devblogs.microsoft.com/typescript/announcing-typescript-3-6/#get-and-set-accessors-allowed-in-ambient-contexts
Don't use https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/#assertion-functions
Don't do recursive types https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/#more-recursive-type-aliases

@benmccann
Copy link
Member Author

There's a PR pending up update tsutils, but that library looks abandoned and hasn't had any updates in over a year

@benmccann
Copy link
Member Author

@dummdidumm I just noticed your edit, so changed it to 3.7 per your suggestion

@benmccann benmccann merged commit 91376d2 into sveltejs:master Dec 14, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants