Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insertion order of if blocks and their anchors #571

Merged
merged 2 commits into from
May 6, 2017
Merged

Conversation

Rich-Harris
Copy link
Member

Fixes #569, but ensuring that if-block anchors are mounted after the if-block contents (the anchors are needed for updating — i.e. if a block is added/removed — rather than for the initial mounting)

@codecov-io
Copy link

codecov-io commented May 6, 2017

Codecov Report

Merging #571 into master will decrease coverage by 0.06%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   94.48%   94.42%   -0.07%     
==========================================
  Files          95       95              
  Lines        2776     2762      -14     
==========================================
- Hits         2623     2608      -15     
- Misses        153      154       +1
Impacted Files Coverage Δ
src/generators/dom/visitors/IfBlock.js 98.87% <93.33%> (-1.13%) ⬇️
src/generators/dom/Block.js 96.77% <0%> (-0.11%) ⬇️
src/generators/dom/visitors/EachBlock.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a67d2...6dfb568. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 86e05aa into master May 6, 2017
@Rich-Harris Rich-Harris deleted the gh-569 branch May 6, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants