Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add notes to stress call-during-initialisation #5631

Merged
merged 2 commits into from
Jun 26, 2021
Merged

doc: Add notes to stress call-during-initialisation #5631

merged 2 commits into from
Jun 26, 2021

Conversation

outloudvi
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@outloudvi outloudvi marked this pull request as ready for review November 1, 2020 16:18
@outloudvi
Copy link
Contributor Author

I'm sending this PR because I experienced such problems recently. I was using getContext() in onMount(), which is incorrect, but it was working in Svelte around 3.24.0. It doesn't work anymore in the new versions of Svelte (such as 3.29.4). Therefore, I think it would be helpful to stress this since getContext() is pretty popular.

@dummdidumm
Copy link
Member

The paragraph was repetitive to a section above in the tutorial, so incorporated this stress-call up there.

@dummdidumm dummdidumm merged commit 92422fd into sveltejs:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants