Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extension to request to support webpack 5 #5624

Merged
merged 2 commits into from
Nov 9, 2020
Merged

add extension to request to support webpack 5 #5624

merged 2 commits into from
Nov 9, 2020

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Oct 31, 2020 •
edited
Loading

Fixes #5617

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

WofWca
WofWca approved these changes Nov 7, 2020
View reviewed changes
Copy link

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was concerned about it not working for CJS, but taking a glace at tests/ made me think they cover it, so all good.

@Conduitry Conduitry merged commit f7bddb2 into sveltejs:master Nov 9, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
add extension to request to support webpack 5 (sveltejs#5624)
e133820
@Conduitry Conduitry mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WofWca WofWca WofWca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

svelte is an invalid ES Module
3 participants
@tanhauhau @WofWca @Conduitry