Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track kind added for video element #5523

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Track kind added for video element #5523

merged 1 commit into from
Oct 22, 2020

Conversation

irshad
Copy link
Contributor

@irshad irshad commented Oct 13, 2020 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

irshad
irshad commented Oct 13, 2020
View reviewed changes
site/content/tutorial/06-bindings/10-media-elements/app-a/App.svelte
Comment on lines +115 to +117
on:mousedown={handleMousedown}>
<track kind="captions">
</video>
Copy link
Contributor Author

@irshad irshad Oct 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Conduitry Thank You! Added at app-a & app-b both version of the tutorial,

@Conduitry Conduitry merged commit f3adbb2 into sveltejs:master Oct 22, 2020
@izumiiii izumiiii mentioned this pull request Oct 28, 2020
Merged
4 tasks
hontas added a commit to hontas/svelte that referenced this pull request Oct 29, 2020
@hontas
Merge remote-tracking branch 'upstream/master'
527c14d 
* upstream/master: (140 commits)
  support $$props and $$restProps for custom elements (sveltejs#5608)
  Bump eslint-config to 5.5.0 (sveltejs#5599)
  update changelog
  add Node and Element as known globals (sveltejs#5601)
  docs: fix a11y warning in media elements example (sveltejs#5606)
  Curly braces linting fixes (sveltejs#5585)
  refactor sourcemap and preprocessor tests (sveltejs#5583)
  -> v3.29.4
  fix code generation error with nullish coalescing operator and logical operators (sveltejs#5564)
  -> v3.29.3
  -> v3.29.2
  -> v3.29.1
  docs: fix a11y warning in media elements tutorial (sveltejs#5523)
  update changelog
  get context at start of {#if} update block instead of at the end (sveltejs#5531)
  update changelog
  only allow passing functions to lifecycle functions (sveltejs#5529)
  update changelog
  fix compiler hanging on <slot slot="..."> (sveltejs#5536)
  Add svelte@next caveat to bug report template (sveltejs#5561)
  ...
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@irshad @taylorzane
docs: fix a11y warning in media elements tutorial (sveltejs#5523)
170b953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irshad @Conduitry