Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update keyed each when key expression changes #5447

Merged
merged 4 commits into from
Sep 24, 2020
Merged

update keyed each when key expression changes #5447

merged 4 commits into from
Sep 24, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5444

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau changed the title add dynamic dependencies for key changes update keyed each when key expression changes Sep 23, 2020
@Conduitry Conduitry mentioned this pull request Sep 24, 2020
Merged
4 tasks
@Conduitry Conduitry merged commit 41d1656 into sveltejs:master Sep 24, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5444 branch September 25, 2020 01:03
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
update keyed each when key expression changes (sveltejs#5447)
566dc54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyed each is not reactive to key expression dependencies
2 participants
@tanhauhau @Conduitry