Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5247 - do not declare variable for member assignment in reactive declaration #5251

Merged
merged 2 commits into from
Aug 12, 2020
Merged

fix #5247 - do not declare variable for member assignment in reactive declaration #5251

merged 2 commits into from
Aug 12, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5247

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/fix-5247 branch from bb6a1b6 to 4159d22 Compare August 8, 2020 08:09
@tanhauhau tanhauhau force-pushed the tanhauhau/fix-5247 branch from 4159d22 to ab85c2b Compare August 8, 2020 09:00
@Conduitry Conduitry changed the title fix #5427 - do not declare variable for member assignment in reactive declaration fix #5247 - do not declare variable for member assignment in reactive declaration Aug 12, 2020
@Conduitry Conduitry merged commit 5194f59 into sveltejs:master Aug 12, 2020
@tanhauhau tanhauhau deleted the tanhauhau/fix-5247 branch August 12, 2020 19:07
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
do not declare variable for member assignment in reactive declaration…
32ca324 
… in SSR (sveltejs#5251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifier xxx has already been declared
2 participants
@tanhauhau @Conduitry