Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix collapsing html with static contents #5059

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5040

  • we collapsed text nodes for optimisation

if (last_child && last_child.node.type === 'Text') {
(last_child as Text).data = data + (last_child as Text).data;
continue;

so, we should use TextWrapper#data instead of TextWrapper#node.data

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5040 branch from 6b6c539 to 8933a37 Compare June 24, 2020 11:46
@Conduitry Conduitry merged commit 55c8096 into sveltejs:master Jun 25, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5040 branch July 15, 2020 15:14
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour between dev server and build after html comment
2 participants