Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assigning item in each not reactive #4945

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #4744
Fixes #4574

Works similarly as binding item in {#each} block.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/assigning-in-each branch from 4acae11 to 2d2bd5b Compare May 31, 2020 16:06
@tanhauhau tanhauhau added the each label May 31, 2020
@Conduitry Conduitry merged commit 0f43ad4 into sveltejs:master Jun 8, 2020
@tanhauhau tanhauhau deleted the tanhauhau/assigning-in-each branch June 9, 2020 00:39
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants