-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix auto crlf issue #4915
fix auto crlf issue #4915
Conversation
Thanks for investigating running on Windows @pushkine. Can you add a bit of description to the PR? The CI does run on Windows and all the tests pass on Windows, so I'm wondering why this is necessary. I saw at one point in your earlier PR that you removed the svelte/.github/workflows/ci.yml Line 11 in f46b38a
How does that tie in? If you do that while checking out locally does it make the tests pass on Windows for you? (not that I'm suggesting that would necessarily be the best long-term solution, but I'm just trying to understand the issue you're running into) |
Basically hundreds of tests will fail on windows machines unless you clone the repository with the |
Instructions are in the readme. https://github.com/sveltejs/svelte/blob/master/README.md#L37-L40 |
The note in the readme and the |
Done, let me know if there's anything else |
This reverts commit 9cbd760.
No description provided.