fix binding for each block local variable #4861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4757
Fixes #4517
Changes:
[bindingGroup].forEach(group => {
loop to just usebindingGroup
.{#each}
, always replace the lhs object toeach_value[each_index]
form. and also remove thearray
variable from the bind callback. ie:Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)