feat: instant-set for zero duration #4766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4399
This is something I recently needed again, I wanted to immediately set the store to a new value from the authoritative source and then start a tween based on the given rate of change of the value towards the min/max (depending on direction of change). I was getting weird numbers using the
{ duration : 1 }
hack until I made the tweened.set()
call live in a rAF which just seemed silly.Now, if you call
.set(<value>, { duration : 0 })
it'll just set immediately and as a bonus do way less work! Added a test that fails w/o this PR (though it fails due to node not havingrequestAnimationFrame
, not due to the value not setting instantly).Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)