Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if_block exists check missing in block.p #4633

Merged
merged 2 commits into from
Apr 23, 2020
Merged

if_block exists check missing in block.p #4633

merged 2 commits into from
Apr 23, 2020

Conversation

pushkine
Copy link
Contributor

@pushkine pushkine commented Apr 5, 2020 •
edited
Loading

#4629 fix
untested
update : it works

@Conduitry
Copy link
Member

Thanks! I think something else needs to also happen in render_compound_with_outros() because in the example in the issue if I add a transition to either of the divs in the {#if}, I'm still getting a similar exception.

@pushkine
Copy link
Contributor Author

pushkine commented Apr 6, 2020

that fixes your exception, there might be others

@dritter dritter mentioned this pull request Apr 14, 2020
Closed
@Conduitry Conduitry merged commit 3ed11fa into sveltejs:master Apr 23, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@pushkine @taylorzane
add if_block existence check in block.p (sveltejs#4633)
9847fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antony antony antony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pushkine @Conduitry @antony