Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded fragment block #4568

Merged

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau added the slot label Mar 17, 2020
@tanhauhau
Copy link
Member Author

tanhauhau commented Mar 19, 2020

CI error:

 * [new tag]         v3.9.2                -> v3.9.2
git checkout --progress --force 58d3628d5cbc8b56f6dee9ab1552f632951fca8d
##[error]fatal: reference is not a tree: 58d3628d5cbc8b56f6dee9ab1552f632951fca8d
Removed matchers: 'checkout-git'
##[error]Git checkout failed with exit code: 128
##[error]Exit code 1 returned from process: file name '/home/runner/runners/2.165.2/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Repository.v1_0.CheckoutTask, Runner.Plugins"'.

it seemed like when it failed like this, i need to push a new commit hash to force the CI to run correctly again

@Conduitry
Copy link
Member

Is there an issue or bug that this is intended to fix, or is it an optimization?

@tanhauhau
Copy link
Member Author

It's an optimisation

@Conduitry Conduitry merged commit cc1f2c6 into sveltejs:master Mar 22, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants