Internals: Scheduler: Fix infinite loop in flush #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shows how onMount is called repeatedly when creating a component dynamically. The loop counter is totally arbitrary and is there to prevent a hard-crash in the CI.
The set that was added to block infinite loops wasn't actually doing anything. Lift the declaration outside of the function and clear it at the end.
ghost
deleted the
jesseskinner
pushed a commit
to jesseskinner/svelte
that referenced
this pull request
Feb 27, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3218
Turns out the set added to prevent infinite loops wasn't performing as planned since it was being reset with every call to
flush().This PR moves the set outside of the function, rearranges the insertion order so that we actually catch recursion, and clears it at the end of the function.
Also added a failing test to make sure it stays fixed.