fix deriving from RxJS observables #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 21, 2020
tanhauhau
reviewed
Jan 22, 2020
src/runtime/internal/utils.ts
Outdated
| @@ -48,8 +48,8 @@ export function validate_store(store, name) { | |||
| } | |||
| } | |||
|
|
|||
| export function subscribe(store, callback) { | |||
| const unsub = store.subscribe(callback); | |||
| export function subscribe(store, ...args) { | |||
There was a problem hiding this comment.
nit: ...callbacks instead of ...args?
jesseskinner
pushed a commit
to jesseskinner/svelte
that referenced
this pull request
Feb 27, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4298. I'm not convinced this is the best way to handle this though. Making the
subscribehelper accept a...rest param might not be worth it just to make the code slightly more DRY.