Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass compiler version in dev events #4154

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

RedHatter
Copy link
Contributor

@RedHatter RedHatter commented Dec 24, 2019

Includes the compiler version in all dev events. As the compiler internals change having the version number to test against should make things much simpler.

fixes #4047

Copy link
Member

@antony antony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only minor change I might suggest is that the replace plugin is configured twice here, with the same options. It could be extracted up a level and made common, but that may be sacrificing readability for DRY, so I'm undecided.

@Conduitry Conduitry merged commit 646c3df into sveltejs:master Jan 5, 2020
@opensas
Copy link
Contributor

opensas commented Jun 9, 2020

Is there some way I can access this svelte version from the code? I mean to programatically access the svelte version to display it from a component, for example

@tanhauhau
Copy link
Member

@opensas svelte.VERSION

next time please ask in the Discord channel instead of commenting on a closed PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose svelte version in dev mode
5 participants