Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: text util: preserve space after svg <tspan> tags #4107

Merged
merged 2 commits into from Dec 23, 2019
Merged

compiler: text util: preserve space after svg <tspan> tags #4107

merged 2 commits into from Dec 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2019

Fixes #3998 and adds a run-time test to make sure it stays fixed.

Note that I chose to nest the if statements because I have a feeling we'll need to fix other svg stuff in the future.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry Conduitry merged commit f287736 into sveltejs:master Dec 23, 2019
@ghost ghost deleted the issue/gh-3998 branch December 23, 2019 20:43
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace is removed around <tspan> elements
1 participant