Add aria-hidden=true to resize-listeners
#3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
force-pushed
the
3948-resize-a11y
branch
from
5af30b8 to
d1df52c
Compare
|
Nice. That's the only one, unless we follow through on the style properties RFC |
Conduitry
added a commit
to mrkishi/svelte
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
aria-hidden="true"to objects generated by `add_resize_listener. This removes them from the accessibility API completely, ensuring that these objects will not interfere with assistive software.Is this the only place we are creating objects in this manner? Are there any other compiler-generated elements that exist for functional rather than structural purposes?
I assume we're still doing the chanelog thing so I threw one in there.
Fixes #3948.