fix range input if max is changed at same time as value #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertLucianto
force-pushed
the
fix/bind-value-fails-range-max
branch
from
d9a1d96 to
149929b
Compare
|
Thank you! This seems like the right way to fix it, I don't think I can think of a situation where you wouldn't want to handle attributes first. Yeah, JSDOM has a few gaps like that. Just can't bring myself to suggest switching the entire test suite over to Puppeteer, it takes long enough to run as it is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3857
This bug is caused by html input range where setting
valueoutside theminandmaxwill fallback to the nearest valid value. In this case, it will be themax.In
ElementWrapper, adding bindings happened before adding attributes, which meansvalueis updated beforemaxwhen updating at the same cycle. I think the issue can be solved by reordering adding attributes to be first.However, I can't seem to reproduce the input range behaviour in test. I think there's something missing in input range validation in jsdom, so I put a note there. I hope it's okay.
Really appreciate for your review!