fix trying to update unmounted input #3848
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3763
Referring to the issue, when an
InlineComponent
is rendered inside a slot, it is always instantiated and subscribes to the store without being mounted. As a result, when the store is updated it fails because it's trying to set the value to an unmounted input element.I tried conditionally instantiating the default slot if custom slot is not given, but it breaks on nested-slot test case. So, I think the safest and simplest solution is to check whether the DOM element exists before updating the value.
It's my first time contribution, and really appreciate for your review! 😄
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)