Fix #3634 compound operators in reactive statement #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency
Compound assignments ('x += y', 'x *= y', etc) should have the
left-hand side of the assignment as a dependency.
Conduitry
reviewed
Oct 4, 2019
blackwolf12333
deleted the
fix_#3634_compound_operators_in_reactive_statement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 sets of tests, one for the compound assignment operators (x += y) that did not actually work yet, and one for the update expressions (x--, y++) which already worked but did not have specific tests.
I haven't figured out yet why the update expressions just work, but the test will at least ensure they won't randomly break anymore.
One thing I wasn't exactly sure about is if the way I'm detecting a compound assignment operator is the best way to do it. This should work because I basically took all the operators in the
AssignmentOperatortype except actual assignment and put them in a list. But if ever another operator is added this will have to be added in that list as well which is not optimal.