Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simplified EachBlock helper #3540

Closed
wants to merge 1 commit into from

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Sep 9, 2019

This introduces a EachBlock helper instead of generating specific code for each blocks, as suggested here: #3504 (comment)

So far this is only used in certain conditions, as the full
feature set is not implemented yet.
Also, thinking about this a bit more, maybe instead of a full blown class, it would be a better idea to use some functional helpers? Especially when getting transitions to work would mean that each blocks would essentially pull in all the transition related runtime… I don’t think that’s too desirable.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

So far this is only used in certain conditions, as the full
feature set is not implemented yet.
@Swatinem Swatinem self-assigned this Sep 9, 2019
@Swatinem Swatinem requested a review from Rich-Harris September 9, 2019 18:10
@codecov-io
Copy link

Codecov Report

Merging #3540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3540   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8ca9f...4fea0d4. Read the comment docs.

@Swatinem
Copy link
Member Author

superceded by #3547

@Swatinem Swatinem closed this Sep 10, 2019
@Swatinem Swatinem deleted the eachblock-helper branch September 10, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants