Add a simplified EachBlock
helper
#3540
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
EachBlock
helper instead of generating specific code for each blocks, as suggested here: #3504 (comment)So far this is only used in certain conditions, as the full
feature set is not implemented yet.
Also, thinking about this a bit more, maybe instead of a full blown class, it would be a better idea to use some functional helpers? Especially when getting transitions to work would mean that each blocks would essentially pull in all the transition related runtime… I don’t think that’s too desirable.
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)