API to create and return a component constructor #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor. Added a format called `eval` that returns a string that when called by `eval` will return a Svelte component constructor. Wrote tests for the `create` method, and the `eval` format. All these tests pass.
|
This addresses issue #345 |
Rich-Harris
added a commit
that referenced
this pull request
Mar 7, 2017
|
Thanks so much! Released this as 1.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an API call,
create, that takes a component string, and returns a Svelte component constructor.It also implements the
evalformat, thatcreateuses behind the scenes.evalis just likeiifewith the exception thatevaldoes not set a global variable, but simply returns the result of the IIFE (the component constructor).The
createcall has the following signature:create(source[, options]) -> SvelteComponent.optionsis optional as the format is set toevalautomatically. All other defaults are set as they are withcompile.These changes are accompanied by tests, that all pass.
I made sure to follow the style of the repo to the best of my abilities, please mention any irregularities.