Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code generation when $$props is present #3069

Merged
merged 2 commits into from
Jun 23, 2019
Merged

Fix code generation when $$props is present #3069

merged 2 commits into from
Jun 23, 2019

Conversation

btk5h
Copy link
Contributor

@btk5h btk5h commented Jun 21, 2019

This PR fixes #2725.

The issue was that the code generated for $set references the wrong variable when $$props is present.

@Conduitry Conduitry merged commit 60914b8 into sveltejs:master Jun 23, 2019
@Conduitry
Copy link
Member

Thank you!

@btk5h btk5h deleted the gh-2725 branch June 23, 2019 15:35
@btk5h btk5h mentioned this pull request Jun 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$$props usage in component will freeze bind values
2 participants
@btk5h @Conduitry