Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track whether block is already outroing #3031

Closed
wants to merge 2 commits into from
Closed

track whether block is already outroing #3031

wants to merge 2 commits into from

Conversation

Rich-Harris
Copy link
Member

General sketch of a solution for #3001 (and maybe #2402?). It should probably apply to all if blocks, and maybe non-if-blocks as well, but I started by fixing the narrow repro.

I can't shake the feeling that this is doubling up somewhere, e.g. with the current variable.

Couldn't get a runtime test to fail, oddly, so put the test in the js directory instead.

@Rich-Harris
Copy link
Member Author

So, this affects any block that Svelte tries to remove while it's already being removed: https://svelte.dev/repl/3fe3f164eab4445c9606240080442e59?version=3.5.1. We could add similar if (!outroing_this_thing) guards around each of these blocks, but it's starting to feel very brittle and hacky. Would really prefer if that logic was centralised somehow. For now, staring at some generated code and hoping for inspiration to strike.

@Rich-Harris
Copy link
Member Author

closing in favour of #3046

@Conduitry Conduitry deleted the gh-3001 branch June 19, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant