Fix div nbsp

[efeskucuk]

This fixes #3014

Edit (old) : Now this fails because I did not change the tests yet, but if you are recommending that we filter out nbsp and send it through text, then why don't we stop all filtering, space too, and send everything down text() ? Only js tests fail, html outputs are all expected, and adjacent nbsps no longer gets merged, every nbsp is present.

[Conduitry]

This doesn't feel like the right solution to me. This would only notice that it ought to compress to a nbsp if it were the first character in the text node. And it also wouldn't preserve multiple nbsps. What do you think about instead modifying the regex here so that the presence of even one nbsp marks the text node as not compressible?

[efeskucuk]

This doesn't feel like the right solution to me. This would only notice that it ought to compress to a nbsp if it were the first character in the text node. And it also wouldn't preserve multiple nbsps. What do you think about instead modifying the regex here so that the presence of even one nbsp marks the text node as not compressible?

Edit : Summarized at the top comment.

[Conduitry]

We're using space() and not text() to decrease the size of the compiled component. We previously would have a lot of things where we're inserting text nodes containing "\n\n\t\t\t\t\t\t", which is ugly. See #2258.

What I was suggesting was actually something like #3025. That makes nbsp stop a text node from being compressed to space() in the compiled output.

[efeskucuk]

We're using space() and not text() to decrease the size of the compiled component. We previously would have a lot of things where we're inserting text nodes containing "\n\n\t\t\t\t\t\t", which is ugly. See #2258.

What I was suggesting was actually something like #3025. That makes nbsp stop a text node from being compressed to space() in the compiled output.

Yes, I tried the regex then realized that I can also get rid of space, wanted to ask you if there was a reason space is there.

[efeskucuk]

I am not sure which pr should be given credit at this point, but updated it to your suggestion.

[efeskucuk]

Thank you for taking your time to help.