Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise html/text bindings from DOM #2996

Merged
merged 14 commits into from
Jun 24, 2019
Merged

Conversation

Rich-Harris
Copy link
Member

This is a branch off of #2379 (which apparently I merged already? oops, didn't mean to yet) which initialises html and text bindings from the DOM, if the bindings don't yet have values (just as we do with e.g. <select>). I also tided up some other SSR attribute stuff while I was in the neighbourhood

@Conduitry
Copy link
Member

We should also mention these bindings here and maybe also in the tutorial.

@Rich-Harris
Copy link
Member Author

While adding docs it occurred to me that there's no real reason text and html should be special cases — with almost all other bindings (except bind:group and bind:this) the binding name corresponds to the property (input.checked, video.currentTime etc). So I renamed them to textContent and innerHTML

@Rich-Harris Rich-Harris merged commit aa80da7 into master Jun 24, 2019
@Rich-Harris Rich-Harris deleted the init-contenteditable branch June 24, 2019 17:51
@normano
Copy link

normano commented Jul 5, 2019

In the future, may want to add a note that the bindings were renamed since version x as these bindings were not working for me and I questioned if the doc was correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants