-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of small fixes #2994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Jun 10, 2019
Conduitry
reviewed
Jun 10, 2019
Conduitry
reviewed
Jun 10, 2019
Conduitry
reviewed
Jun 10, 2019
Conduitry
approved these changes
Jun 12, 2019
👏 👏 👏 |
mrkishi
force-pushed
the
cleanup
branch
2 times, most recently
from
June 13, 2019 07:01
336cd34
to
36cae1f
Compare
Conduitry
requested changes
Jun 15, 2019
|
Yeah, the |
Conduitry
approved these changes
Jun 16, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been opening too many little PRs and these would have to be another 7... Instead, let me know if any of these are undesirable and I'll rebase them out!
Removed some files that slipped in and got committed when they shouldn't, 219dd13.
Removed long unused (and broken!)
.flowconfig
file, 6034df7.Pinned
@types/node
: it was at v10, even though we support v8, 43f5680.Pointed the
types
field to declaration files, 616e1eb. Typescript expects it to be a file and doesn't treat it as an entrypoint for.d.ts
files, instead resorting to normal module resolution:master> npx typescript --traceResolution
pr> npx typescript --traceResolution
Moved the sub-packages stub creation to build as per @Conduitry's plead, 2695d76.
Split
tsconfig.json
into multiple projects:compiler
,runtime
andtest
. Each of these have different libraries and environments, so we can be more selective in what typescript provides them, 29b5218.Forced git to use unix line endings since tests fail on Windows otherwise, see Test suite passes on Mac, fails on Windows #2817, a08576f.