Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.ts without dependencies #2832

Closed
wants to merge 1 commit into from
Closed

store.ts without dependencies #2832

wants to merge 1 commit into from

Conversation

sanderhahn
Copy link
Contributor

Was looking at issue #2786 (Don't bundle the store) and this is just an idea/proposal. Because i am not sure what the unintended consequences are and if this would resolve them. This pull request makes store.ts independent of internal by inlining as workaround.

@Conduitry
Copy link
Member

Inlining them is not what we want - this gives pretty much the exact same result as we already have now with bundling the store: stuff from internal is getting duplicated between internal and store. A short term fix is probably going to involve setting the external option on rollup when bundling. A longer term fix might be something like #2790.

@Conduitry Conduitry closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants