Allow multiple event listeners on a single node #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this sounds like a reasonable enhancement. Can you swap out the parser test though for a runtime test (like the others in |
Conduitry
reviewed
May 7, 2019
src/parse/state/tag.ts
Outdated
| @@ -376,6 +368,15 @@ function read_attribute(parser: Parser, unique_names: Set<string>) { | |||
| const colon_index = name.indexOf(':'); | |||
| const type = colon_index !== -1 && get_directive_type(name.slice(0, colon_index)); | |||
|
|
|||
| if (unique_names.has(name) && type != "EventHandler") { | |||
There was a problem hiding this comment.
Suggested change
| if (unique_names.has(name) && type != "EventHandler") { | |
| if (unique_names.has(name) && type !== "EventHandler") { |
Not that it would really matter here, but we are trying to use non-coercion comparisons everywhere.
Conduitry
reviewed
May 7, 2019
src/parse/state/tag.ts
Outdated
| }, start); | ||
| } | ||
|
|
||
| unique_names.add(name); |
There was a problem hiding this comment.
It might be nicer to not even add to unique_names if we have a type of "EventHandler".
|
@Conduitry I've implemented your suggestions into the pr. |
|
Thanks, this is a nice enhancement |
|
Should the documentation be updated? |
ematipico
added a commit
to ematipico/svelte
that referenced
this pull request
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2688