-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: document rest in array/object destructuring in each blocks #2677
Conversation
a361dd3
to
712e807
Compare
712e807
to
b34f04d
Compare
I'm really wary about having 'since version such-and-such' notices in the API docs. This will become unreadable very soon unless it's done very unobtrusively. (FWIW, there also also some other new 3.1.0 and 3.2.0 features that don't currently/yet have such notes about this.) Even if this is done unobtrusively, I'm still concerned about it resulting in sort of an append-only-docs situation. We don't want stuff to end up in its own paragraph solely because it was added in a later version. If it makes more sense to slip it in between (or partially replace) some existing documentation, we want to be free to do that, without being being hampered by finding an unambiguous place to put the 'since x.x.x' or an icon or whatever. |
I think generally I'd leave it out. Although there could be a consideration made to add notes or mentions of when it was added over the last minor version, to ease finding what changed in terms of features available. Generally I'd still refer to that through a well maintained |
c8ead68
to
63e4049
Compare
63e4049
to
369b087
Compare
I've removed all the substitutions |
Closes #2676
Also completed the substitution of the code blocks language from
html
tosv
where applicable.