Don't show 'Empty block' warnings for non-existent await branches #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems like a reasonable approach to me, we can optimise the empty blocks away another time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Empty blockwarnings from non-existentawaitbranches and closes #1716.The warnings are currently generated because a
PendingBlock,ThenBlock, andCatchBlockare always created for everyAwaitBlock. By introducing askipboolean in the node info of these blocks and setting it tofalseonly when the branch is used, we can useskipto conditionally callwarn_if_empty_block.I first started experimenting with only adding pending, then, and catch to the await block if they were used, but that had ripples throughout the codebase, so I'm not sure if that's desired for such a small fix as this one.