Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show/hide nav when clicking in docs sidebar #2530

Merged

Conversation

thollander
Copy link
Contributor

  • Listens to hashchange event

  • Changes only the visibilty when not triggered by hashchange

Resolves #2456

- Listens to hashchange event

- Changes only the navbar visibilty when scroll not triggered by hashchange

Resolves sveltejs#2456
@thollander thollander force-pushed the fix/navbar-conflict-with-sidebar branch from fd0897b to fcfe2b4 Compare April 23, 2019 21:04
@Conduitry Conduitry merged commit 93f7ecc into sveltejs:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show/hide nav when clicking in docs sidebar
2 participants