Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner fix #2461

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Banner fix #2461

merged 2 commits into from
Apr 21, 2019

Conversation

munrocket
Copy link
Contributor

We have a problem with loading picture in the readme. Just threw it on imgur.

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #2461 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39afa1c...5de7d32. Read the comment docs.

@Rich-Harris
Copy link
Member

What was the problem? I think it's better to keep it with the repo if possible — does it just need to be an absolute URL? We could use https://raw.githubusercontent.com/sveltejs/svelte/master/banner.png if so

@munrocket
Copy link
Contributor Author

People downloaded this picture too frequently and github decides not to show it anymore. Maybe you have a cached version in browser.

@Rich-Harris
Copy link
Member

huh! that's very weird. I've swapped it out for https://svelte-assets.surge.sh/banner.png, since at least we control that. Thanks for the heads up

@Rich-Harris Rich-Harris merged commit f135c64 into sveltejs:master Apr 21, 2019
@munrocket
Copy link
Contributor Author

It works now, thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants