Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create fallback content if no slot is provided #2409

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #2354

@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #2409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2409   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079a1ba...d67ffcd. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 3f97558 into master Apr 13, 2019
@Rich-Harris Rich-Harris deleted the gh-2354 branch April 13, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot fallback content shown when rehydrating
2 participants