API docs: remove an absolute URL #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally started this PR because the link `[stores](tutorial/writable-stores)` renders as http://localhost:3000/tutorial/writable-stores on https://v3.svelte.technology/docs#svelte-store. No idea why because the rest of the relative links in content/ have the same format.
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 1 1
Lines 49 49
=======================================
Hits 45 45
Misses 4 4Continue to review full report at Codecov.
|
|
There was a PR #2352 that was opened for that which I merged but which probably just hasn't been deployed. Removing this other absolute URL does also make sense though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally started this PR because the link
[stores](tutorial/writable-stores)renders as http://localhost:3000/tutorial/writable-stores on https://v3.svelte.technology/docs#svelte-store.
No idea why because the rest of the relative links in content/ have the same format.