-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow transition functions to return nothing #2246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
=========================================
Coverage ? 91.83%
=========================================
Files ? 1
Lines ? 49
Branches ? 0
=========================================
Hits ? 45
Misses ? 4
Partials ? 0 Continue to review full report at Codecov.
|
Does it make sense to just merge this in its current form and open up a separate issue for optimizing this? |
yeah, fair enough. brought it up to date with master, but there's some TypeScript bullshit to deal with |
What do you think about a similar change for #3300 where we have a |
That seems reasonable, yeah. I couldn't quite tell if |
Allows a transition function to return nothing, indicating no transition should take place.
There's a better way to do this, which is not running the transition at all (rather than running and immediately canceling), but it involves some fiddling to ensure outros still happen at the correct time, so I'm just going to leave this as a note to self