Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded REPLs #1901

Merged
merged 13 commits into from
Dec 24, 2018
Merged

embedded REPLs #1901

merged 13 commits into from
Dec 24, 2018

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 23, 2018

Adds a /repl/embed page, and uses it to render a few interactive examples on the homepage:

screen shot 2018-12-22 at 9 54 02 pm

TODO:

  • The transition example needs some more work (not least because transitions are currently broken in v3)
  • the layout is a bit rubbish when the screen is narrow
  • use demo= instead of gist=, so the examples are versioned

@Conduitry
Copy link
Member

I understand if you don't want to deal with it for now, but I think we want to try to use the demo= mechanism instead of using Gists for this.

@Rich-Harris
Copy link
Member Author

Yeah, I guess you're right. I've updated the TODO list in the top comment

@Conduitry
Copy link
Member

I just updated the demos to use the integrated easing and transition functions. The embedded transition example's custom-transitions.js should also use them.

@Rich-Harris
Copy link
Member Author

working on it as we speak — also moving over to the demo= thing

@Rich-Harris Rich-Harris merged commit 93f37c3 into master Dec 24, 2018
@Rich-Harris Rich-Harris deleted the embedded-repl branch December 24, 2018 00:14
@Rich-Harris
Copy link
Member Author

guess i should have squashed this branch huh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants