Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message in the Store #1761

Merged
merged 3 commits into from
Oct 17, 2018
+2 −2
Merged

Update error message in the Store #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74b11a6
Update store.js
dmitry-kurmanov Sep 27, 2018
07b7212
Update index.js
dmitry-kurmanov Sep 27, 2018
ebc7eeb
Merge branch 'master' into patch-1
dmitry-kurmanov Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ assign(Store.prototype, {
let dirty = false;

for (const key in newState) {
if (this._computed[key]) throw new Error(`'${key}' is a read-only property`);
if (this._computed[key]) throw new Error(`'${key}' is a read-only computed property`);
if (this._differs(newState[key], oldState[key])) changed[key] = dirty = true;
}
if (!dirty) return;
Expand Down
2 changes: 1 addition & 1 deletion test/store/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ describe('store', () => {

assert.throws(() => {
store.set({ bar: 'whatever' });
}, /'bar' is a read-only property/);
}, /'bar' is a read-only computed property/);
});

it('allows multiple dependents to depend on the same computed property', () => {
Expand Down