Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always stringify text node data #1627

Merged
merged 3 commits into from
Aug 4, 2018
Merged

Always stringify text node data #1627

merged 3 commits into from
Aug 4, 2018

Conversation

Rich-Harris
Copy link
Member

Alternative fix for #1598, which causes {null} to render as "null" instead of the empty string, which I think is more in line with how Svelte makes these decisions elsewhere.

The addition of a new helper is unfortunate, though at least it will minify better, I guess...

x.data=y.thing;
a(x,y.thing);

@Rich-Harris Rich-Harris merged commit 6012c96 into master Aug 4, 2018
@Rich-Harris Rich-Harris deleted the gh-1598 branch August 4, 2018 14:59
@Rich-Harris Rich-Harris mentioned this pull request Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants