feat: Restrict types for Spring and Tween #14862
Draft
+33
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Improve Spring data typing, or improving it so it doesn't bother about unsupported data types #14851
This PR introduces the
MotionPrimitive
andMotionRecord
data types to accurately reflect what the algorithms of the Spring and Tween classes can handle.The alternative would be to remove the throwing whenever an unsupported data type is found, but I suppose that is a breaking change and if that's the preferred route, then it would have to wait for Svelte v6. Therfore, this PR should greatly increase the accuracy of Intellisense when using Spring and Tween.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint