cross-platform test setup via shelljs #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My attempt at solving sveltejs#1478
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 124 124
Lines 4579 4579
Branches 1443 1443
=======================================
Hits 4174 4174
Misses 159 159
Partials 246 246Continue to review full report at Codecov.
|
tivac
commented
May 17, 2018
test/cli/index.js
Outdated
| }); | ||
|
|
||
| done(); | ||
| // }); |
There was a problem hiding this comment.
Oops, I left in some cruft from my experimentation. Will remove when I get a chance!
|
I think we're good to go now, I've gotten the tests all passing. Thanks for the |
|
Just did a touch more tidying. Removed the cruft and also made it so that the test samples can once again be full commands (including the |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at solving #1478
shelljsinstead of raw shell commandsaliassince there isn't a good cross-platform version of that.shfiles so they aren't quite complete commands any more, hopefully they're still close enough.I'm still getting local failures that look like line-ending differences, but the file contents & directory structure look correct now.