Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disregard TypeScript nodes when pruning CSS #14446

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Nov 26, 2024

Fixes #14204 — this refactors get_possible_element_siblings to make it non-recursive, and use context.path and fragment.nodes rather than node.parent and node.prev. We should now be able to get rid of all references to those properties, but I'll do that in a separate PR.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 732da83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14446

@Rich-Harris Rich-Harris changed the title chore: simplify get_possible_element_siblings fix: disregard TypeScript nodes when pruning CSS Nov 26, 2024
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This code is simpler to read too.

@Rich-Harris Rich-Harris merged commit a6ad5af into main Nov 26, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the simplify-get-possible-element-siblings branch November 26, 2024 19:05
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong CSS "Unused CSS selector"
2 participants